Luka Markušić

Results 459 comments of Luka Markušić

It runs `cmd /c nvim` in the background.

That's odd, it first checks for [os.editCommand](https://github.com/jesseduffield/lazygit/blob/82fc6fb111ba94aaabf78a00396e69689b860655/pkg/commands/git_commands/file.go#L31), and only if that's empty does it check git's editor and whatnot. What does the log (bottom right panel) say after opening a...

Yup, according to the source: ``` // runs git commit without the -m argument meaning it will invoke the user's editor func (self *CommitCommands) CommitEditorCmdObj() oscommands.ICmdObj { return self.cmd.New(fmt.Sprintf("git commit%s%s",...

Well, it's not _file editing_ per se, it's _committing_. We could add this, but given the confusion regarding `edit` and `commit`, I doubt anyone would benefit from it: ``` commitChanges:...

Checking the log shows the following happens when deleting a commit: ``` git rebase --interactive --autostash --keep-empty ``` And then the commit is marked as `drop` and the rebase continues....

Well, rebasing over merge commits is [somewhat unintuitive](https://stackoverflow.com/questions/4783599/rebasing-a-git-merge-commit) in general, so I do get the confusion :) Also, why do you merge and then delete the merge commit, are you...

This isn't really an issue with `lazygit` itself, but with `nvim` then, right? Take a look at how do existing [plugin](https://github.com/kdheepak/lazygit.nvim)s manage to make it work.

> We'll need to ensure we're able to cache the docker image Performance reasons or github action limits of some sort?

[This](https://github.com/jesseduffield/lazygit/pull/2452) should fix it, feel free to build from the branch until it gets merged.