Mark Elliot

Results 26 comments of Mark Elliot
trafficstars

Thanks! Sorry it took so long to put something together.

Confirming this appears to be fixed in 7.2.0. Thanks!

@fmeum yes, that’d be helpful, thanks. What i know so far: - in 1.26.x, commons-compress started calling Charset.forName(encoding) for the encoding passed to TarArchiveInputStream - There’s no path (today) to...

@fmeum there’s a difftest for that file that fails without the change. Haven’t looked at why the update causes it to be required just yet.

via jdeps for commons-compress and its dependencies commons-io, commons-codec, and commons-lang3: ``` org.apache.commons.compress -> java.desktop org.apache.commons.compress.harmony.pack200 -> java.beans java.desktop org.apache.commons.compress.java.util.jar -> java.beans java.desktop requires java.desktop org.apache.commons.lang3 -> java.desktop org.apache.commons.lang3.concurrent ->...

@fmeum it looks like deny-listing the classes that were pulling in java.beans/java.desktop has reined in the bloat from ~50MB to around 3MB -- and weirdly the 3MB only seems to...

In case it's helpful: ``` 364K commons-codec-1.17.0.jar 1.0M commons-compress-1.26.1.jar 497K commons-io-2.16.1.jar 643K commons-lang3-3.14.0.jar ```

Before I started down the path, I repeated the failing test linked at the top of COMPRESS-654 and then updated commons-compress to 1.26.1 to find that with new commons-compress I...

Yep, that's what I tried before getting started.

@Wyverald ready for another look when you have a moment -- updated the PR description to explain the fix that's applied here, and with @fmeum's help there's now a test...