Mark Petersen

Thanks @jonbob for the testing. With this PR, the AMOC is a bit stronger, but longer runs may turn out similar.  Other statistics in the 30-year run also look...

@sbrus89 and/or @knbarton, could you run this through your standard test with tides and confirm that the harmonic analysis member produces bit-identical results between master and this PR? This now...

@knbarton thanks for testing. I fixed that segfault issue in https://github.com/E3SM-Project/E3SM/pull/5201. Please confirm that, with that fix in place, you are also satisfied with this PR.

@sbrus89 and @knbarton please test again. Harmonic analysis output should be bfb with master.

[This is the metric](https://web.lcrc.anl.gov/public/e3sm/diagnostic_output/ac.vanroekel/E3SMv2/20220715.submeso.piControl.ne30pg2_EC30to60E2r2.chrysalis/mpas_analysis/ts_0001-0750_climo_0701-0750/ocean/index.html#moc&gid=18&pid=5) that shows the major change due to turning on the mesoscale eddy parameterization: 

Adding reviewers from the AMOC working group, who were involved in these changes. The code is already in. Here we simply turn it on. Your approval here really says that...

This PR requires that #5167 and #5171 be merged first. Updating the MOC calculation #5170 is needed to produce the same AMOC statistic as above.

Coordinated with Luke: rebased on master after #5171 merge. Compiled with gnu and intel, tested with nightly stand-alone suite with gnu debug and `config_submesoscale_enable` set to both true and false.

Tested this PR on Chrysalis with ``` ./create_test SMS_D.T62_oQU120_ais20.MPAS_LISIO_TEST.chrysalis_gnu -q acme-small --walltime 30:00 ``` and it died on run start-up with the problem in #5204. I'll see if I can...

Thanks all. This is a big accomplishment. There were sufficient reviewers, so I'm removing LeAnn and Alice, who are out.