automapper-plus icon indicating copy to clipboard operation
automapper-plus copied to clipboard

Throw Exception instead "return;"

Open Slayer911 opened this issue 5 years ago • 2 comments
trafficstars

Please, change this comment to real exception https://github.com/mark-gerarts/automapper-plus/blob/d5ca462e99deae8c6628d15d5c67ab479ad1b8b9/src/MappingOperation/DefaultMappingOperation.php#L49 When this library is one block of big system, bugs like this is hard detection, if here will be real exception, life will be better, i think

Slayer911 avatar Feb 20 '20 12:02 Slayer911

Yes, you are right. However, throwing an exception here could be a backwards incompatible change. I will definitely incorporate this in the 2.0 release though. Thanks for reporting!

mark-gerarts avatar Feb 22 '20 12:02 mark-gerarts

Thank for great library)

Slayer911 avatar Feb 25 '20 11:02 Slayer911