flamerobin icon indicating copy to clipboard operation
flamerobin copied to clipboard

Wrong "Create Selectable SP" output

Open arvanus opened this issue 5 years ago • 6 comments

(Same bug for EXECUTE BLOCK statement) image

image image Output: image If I change in View->Preferences->Fields to "Only show datatype" it creates correctly: image (but ideally would be to show the domain) image With show both domain and datatype, appears like this (bug): image

I think that the same routine is used both for initial TreeView and for this, I think that when extracting FR would need to use the field domain when existing and the datatype elsewhere. I would like to get some suggestions of what would be the most "elegant" way to give to the user this SQL

Thanks

arvanus avatar Aug 26 '20 18:08 arvanus

I created two new types of parameters

  • Source
  • TypeOf. Please see selectable procedure for a example of "Type Of" and selectable Execute Block for a example of "Source"

Jdochoa avatar Mar 01 '21 07:03 Jdochoa

Hi @arvanus,

Is this issue still reproducible in 0.9.3.8 Snapshot version?

luronumen avatar Jun 07 '21 11:06 luronumen

Hi, almost there! At "Create selectable stored procedure", it's correctly using "type of" At "EXECUTE BLOCK", it's always using the domain, even when there is no domain so it's using RDB$##, needs to fix this: image

Note: type of column was add at Firebird 2.5, so this might be optional https://firebirdsql.org/refdocs/langrefupd25-psql-declare.html

arvanus avatar Jun 07 '21 13:06 arvanus

Hi, almost there! At "Create selectable stored procedure", it's correctly using "type of" At "EXECUTE BLOCK", it's always using the domain, even when there is no domain so it's using RDB$##, needs to fix this: image

Note: type of column was add at Firebird 2.5, so this might be optional https://firebirdsql.org/refdocs/langrefupd25-psql-declare.html

Hi @arvanus

I created two new types of parameters

Source
TypeOf.
Please see selectable procedure for a example of "Type Of" and selectable Execute Block for a example of "Source"

if you need execute block with "Type Of" please change the your local file create_selectable_execute_block For the show type verify you settings.

./jo

Jdochoa avatar Jun 07 '21 15:06 Jdochoa

Yes, but where it's not used a domain, Fr needs to deliver the primary type, not the "RDB$" domain

arvanus avatar Jun 07 '21 18:06 arvanus

Hi @arvanus

Could you please retest this issue on FlameRobin 0.9.3.12 and close it if it is no longer reproducible?

Thanks in advance, Luciano

luronumen avatar Jul 01 '22 12:07 luronumen