flamerobin icon indicating copy to clipboard operation
flamerobin copied to clipboard

Add Support for Identity Columns

Open pgiacomo69 opened this issue 4 years ago • 5 comments

Thanks for your Work!

Currently, when showing table properties or generating its DDL, Identitity attributes for columns are completely ignored. I understand that to manage this property it needs several modifications on Column Property form, but for now it would be very useful to have this information at least showed in Table property page and "Show DDL".

pgiacomo69 avatar Aug 22 '20 08:08 pgiacomo69

ACTUAL RESULT Identity column is displayed as "ID BIGINT NOT NULL" instead of "ID BIGINT GENERATED BY DEFAULT AS IDENTITY NOT NULL"

STEPS TO REPROCUDE THIS ISSUE

  • Double click on a table and then click on DDL;

luronumen avatar Aug 22 '20 14:08 luronumen

Hi @pgiacomo69 , please see https://github.com/Jdochoa/flamerobin/tree/FB3 and help me with feedback

Jdochoa avatar Dec 04 '20 02:12 Jdochoa

Hi @pgiacomo69 , please see https://github.com/Jdochoa/flamerobin/tree/FB3 and help me with feedback

Ok, 0.9.3.5 Snapshot partially solves the issue, altough column property dialog still doesn't work well for identity columns, having it shown in DDL it's ok! Great Work!

pgiacomo69 avatar Jan 02 '21 01:01 pgiacomo69

Hi @pgiacomo69 ,

Is this issue still reproducible in 0.9.3.8 Snapshot version?

luronumen avatar Jun 07 '21 11:06 luronumen

Actually, creating a table: CREATE TABLE table_name ( id integer generated by default as identity primary key, descr varchar(20) );

its ddl from 'Properties' is different:

CREATE TABLE TABLE_NAME ( ID integer GENERATED BY DEFAULT AS IDENTITY NOT NULL, DESCR varchar(20), CONSTRAINT INTEG_92 PRIMARY KEY (ID) );

pgiacomo69 avatar Jun 08 '21 19:06 pgiacomo69