flamerobin icon indicating copy to clipboard operation
flamerobin copied to clipboard

Include MicrosoftVisualC++ VC_redist

Open nLeonardt95 opened this issue 3 years ago • 4 comments

It would be nice if the installer of Flamerobin would install the corresponding version of MicrosoftVisualC++ VC_redist.

nLeonardt95 avatar Nov 22 '21 12:11 nLeonardt95

hi @arvanus

I have a question. I am looking at the script to generate the Windows installers and I see the same file is used for x86 and x64.

https://github.com/mariuz/flamerobin/blob/master/install/win32/FlameRobinSetup.iss#L95:L99

Is it the correct file?

./jo

Jdochoa avatar Oct 28 '22 17:10 Jdochoa

Hi, I don't use this folder anymore, I use a different folder for x86 and x64, hasn't committed the change because I think the best way to build is by running cmake and "follow the flow" from there, so it can be any folder you desire

arvanus avatar Oct 31 '22 00:10 arvanus

Hi, I don't use this folder anymore, I use a different folder for x86 and x64, hasn't committed the change because I think the best way to build is by running cmake and "follow the flow" from there, so it can be any folder you desire

ok. But the correction for this request where are implemented?

Jdochoa avatar Oct 31 '22 22:10 Jdochoa

I have a question. I am looking at the script to generate the Windows installers and I see the same file is used for x86 and x64.

https://github.com/mariuz/flamerobin/blob/master/install/win32/FlameRobinSetup.iss#L95:L99

Is it the correct file?

done, changed for build32 and build64 folders

arvanus avatar Oct 19 '23 02:10 arvanus