mpris-scrobbler icon indicating copy to clipboard operation
mpris-scrobbler copied to clipboard

Per player logic

Open mariusor opened this issue 7 years ago • 6 comments

Since the MPRIS signals and metadata exposed differs on most of the media-players, I should implement some way of having a single point of verification for this information.

Then for each player I could implement this logic differently.

Current observed issues are:

Spotify

  • Doesn't populate correctly the track position property (neither volume, but that's less important for my use case). See ticket.

  • Triggers two signals with the exact same data when the track changes.

Audacious

  • Triggers an properties changed signal every time the track position advances. ~~This leads to very high CPU usage because the scrobbler handles every signal.~~(This might not be that big of a problem) I don't know if there's a way to filter them.

mariusor avatar Nov 30 '17 12:11 mariusor

MPV doesn't work too.

Bergiu avatar Nov 13 '18 11:11 Bergiu

Well, mpv doesn't expose the MPRIS interface, more so it doesn't seem to implement any DBUS functionality.

Unfortunatelly I can't do anything about that. You can open a ticket with mpv, but I doubt that they are interested if they didn't add it until now.

mariusor avatar Nov 13 '18 12:11 mariusor

I've forgot to say, that I'm using this mpv plugin: https://github.com/hoyon/mpv-mpris

With that it is possible to get information and controll the player over mpris with playerctl.

mpris-scrobbler log on vlc: https://hastebin.com/diwujagodo.php

playerctl output on vlc: https://hastebin.com/nuzufolelu.rb

mpris-scrobbler log on mpv with mpv-mpris: https://hastebin.com/qerinomivo.rb

playerctl output on mpv with mpv-mpris: https://hastebin.com/enifugonib.rb

Bergiu avatar Nov 14 '18 10:11 Bergiu

I see.

From your debug log it seems that mpris-scrobbler can't load the track title when using mpv-mpris. I'll try to find the song to reproduce your issue.

I'll ping you if I find a solution.

mariusor avatar Nov 14 '18 10:11 mariusor

It works. Thanks for you work.

Bergiu avatar Nov 19 '18 10:11 Bergiu

No problem, I'm glad that someone is actually using the scrobbler besides me.

mariusor avatar Nov 19 '18 10:11 mariusor