Segfault while selecting a player

[vaygr]

Trying 0.8.5 here.

Even a simple mpris-ctl --player a leads to a segfault, hence none of the commands work on inactive players, if you want to specify, e.g. mpris-ctl --player ncspot pp.

mpris-ctl --player active ... / mpris-ctl --player inactive ... work though.

[vaygr]

Program received signal SIGSEGV, Segmentation fault.
0x0000555555558086 in main (argc=<optimized out>, argv=0x7fffffffdeb8) at src/main.c:266
266	                    memcpy(player_names[player_count++], optarg, MAX_OUTPUT_LENGTH - 1);
(gdb) bt full
#0  0x0000555555558086 in main (argc=<optimized out>, argv=0x7fffffffdeb8) at src/main.c:266
        char_arg = <optimized out>
        status = 1
        name = <optimized out>
        show_help = false
        active_players = false
        inactive_players = false
        player_names = <error reading variable player_names (value requires 81920 bytes, which is more than max-value-size)>
        player_count = 1
        option_index = 0
        long_options = {{name = 0x555555559b23 "player", has_arg = 1, flag = 0x0, val = 1}, {name = 0x555555559aec "help", has_arg = 0, 
            flag = 0x0, val = 2}, {name = 0x0, has_arg = 0, flag = 0x0, val = 0}}
        invalid_player_type = false
        info_format = <optimized out>
        command = <optimized out>
        dbus_method = <optimized out>
        err = {name = 0x0, message = 0x0, dummy1 = 0, dummy2 = 0, dummy3 = 0, dummy4 = 0, dummy5 = 0, padding1 = 0x0}
        conn = <optimized out>
        players = <error reading variable players (value requires 1229920 bytes, which is more than max-value-size)>
        found = <optimized out>

[vaygr]

Hey @mariusor, would you be able to take a look at it?

[mariusor]

Hey @vaygr, sorry for the long delay, I didn't have notifications enabled for this project, so your ticket flew under my radar.

I pushed a new version (v0.8.6) that fixes this issue.