webpack-bundle
webpack-bundle copied to clipboard
By default loading config from config/webpack.config.js and not app/config/webpack.config.js
I think this should be %kernel.root_dir%
not %kernel.project_dir%
https://github.com/mariusbalcytis/webpack-bundle/blob/1737c73cae2d3501272c960a6292ccbd533d9b74/src/DependencyInjection/Configuration.php#L71
AFAIK this is correct. the project dir is the dir where composer.json resides. and if you use new symfony 4 dir structure then the above translates to config/webpack.config.js
@mvrhov This is right, probably a check of \Symfony\Component\HttpKernel\Kernel::VERSION
should be done? What do you think about that, I can do a fast patch if you agree with this.
Unfortunately project structure is not tightly coupled with symfony version. Furthermore, version 1.0 was already released, and this would be backward incompatible change. This behavior is explained in upgrade.md file. Of course, if one is installing fresh copy, it does not make much sense. But at this point, I don't know if the change is really worth it.
@mariusbalcytis It shouldn't be a backwards incompatible change as long as people didn't move their config file. We upgraded the bundle and it was searching in config
on older Symfony version, which doesn't make sense to me. I did miss the UPGRADE.MD
file and now I see that it is addressed there.
Anyway, if you don't think this is something to be fixed please close the issue.