Marius Millea

Results 159 comments of Marius Millea

Implemented @sethaxen's suggestion in https://github.com/JuliaDiff/AbstractDifferentiation.jl/pull/62

Also ran into this, yea the behavior of overwriting is really surprising and undesired. If a PYTHON_JULIAPKG_PROJECT is specified, can it just assume necessary packages are there, and just allow...

Maybe I'm missing something but its hard to imagine a use-case for removing all packages in an existing Project.toml. Perhaps better would just be an error message saying to set...

>Do we want the plot recipes to exactly replicate the PyPlot functionality in plotting.jl? Which functionality specifically do you mean? Is theres something that just wont be possible with Plots?...

Feel free to open a PR to start. I think we rename `plotting.jl` -> `pyplot.jl` and add a `plots.jl`, which would similarly be wrapped in a `@requires`.

Wasn't thinking about this. I forget exactly how `@with_kw` works but if its the same as `@kwdef` it might be as easy as just adding a check for it here...

Just took a look at it, this idea makes a lot of sense to me, thanks! If you can add tests and a note in the readme I'll merge.

This seems to break the readme example fyi, which you may have seen and I'm sure is fixable.

Many thanks for this. Whats happening now is that this just redirects to `@kwdef` so thats why you're not getting any of the nice `@with_kw` stuff. Will need to look...