CompositeStructs.jl icon indicating copy to clipboard operation
CompositeStructs.jl copied to clipboard

Published 20 hours ago • verified publisher icon marius311

Adapt to https://github.com/JuliaLang/julia/pull/48469 ?

Open j-fu opened this issue 9 months ago • 2 comments

Possibly we should adapt to https://github.com/JuliaLang/julia/pull/48469 .

j-fu avatar Mar 02 '25 17:03 j-fu

Tried reading that but failed to understand whats going on. Do you have a better view of how specifically that impacts us?

marius311 avatar Mar 02 '25 23:03 marius311

Yeah essentially the same with me... So basically I lifted the code helping to set up the field docs in the composite structs from there, and there are now some changes. They cite an issue where their old code (similar to the code here) made some problems with static compilation (as far as I understand). It is about the creation of a superfluous Dict in some cases, so not exactly broken functionality-wise.

I don't see any acute need to fix something. If I find time I could try to implement their changes in a PR and see if it works, may be this would help me to understand the issue a little bit better.

An alternative might be depending on REPL which IMHO is not a good idea.

So let's keep this open in the moment.

j-fu avatar Mar 03 '25 12:03 j-fu