improve password recommendations and add domain mappings

[flo-mic]

This pull request makes further improvements in the password recommendations. I was not happy with my last implementation because not all users will get the best recommendations experience, and this is important for a good pasword management. So I decided to make further improvements by removing the extension setting for the search mode again.

The new search behavior for recommendations combines all previous search modes in an intelligent way. So the user will always get the best result based on the given page.

It will search on the following conditions and return all results. The results are ordered in the same way as they are queried here:

• Exact matches
• Host and port matches
• host matches
• domain and domain mapping matches

The new recommendations uses already the new api setting server.domain.mapping to consider also different domains which share the same credentials as described here: https://github.com/marius-wieschollek/passwords/pull/354 But of course the extension can also work without the new api setting to support also old installations.

The password mining was also modified. It will only ask for new passwords if the recommendations do not include a matching user password combination.

[TtuxX]

Any update regarding when we can expect the integration of this great modification to the webextension? :)

[smirkybg]

Hello. I'm using the same credentials for a few web portals and I've joined them in a single password entry to avoid marking them as "Duplicate". My password doesn't get recommended, despite having the website explicitly added to the settings of the password. I believe this PR improves this? If so, can we try to get it reviewed/merged soon?

[flo-mic]

@smirkybg I‘m not sure if this PR gets merged as there is no activity unfortunately.

I implemented some other improvments for the recommendations which are already merged. Are all pages for this password for the same domain? e.g. app1.example.com and app2.example.com or are they from different pages? If so have a look at #151

[smirkybg]

Yes and potentially no. I don't see why they should be? From what I see, a credentials entry can have multiple end-points and multiple types of end-points. Even if we ignore the types and focus primarily on the "Website" type, there are some weird problems:

• when I add subsequent websites to the same credentials object, they cannot be easily searched in the plugin - VERY inconvenient
• when adding more than 2 subsequent (3 in total) Website endpoints to 1 credential object, the suggestions stop working for those credentials. This is proof that there's a bug with indexing the credentials objects. On screenshot 1 we have 2 subsequent endpoints and the credentials ID is visible. After saving a third one and refreshing the plugin, the ID is no longer suggested.