maritz

Results 67 comments of maritz

I actually didn't know about that, thanks. Doesn't really solve the problem though: If there is no node process running to listen to that event*, there is no one to...

That still leaves at least one more problem: If multiple clients with nohm try to "repair-by-delete" after downtime they might run into differences of "opinion" on what objects still exist...

Oh, I'd love that. I never seriously benchmarked it myself. I'm not 100% sure how to actually create meaningful benchmarks for an ORM, though.

Hm, I just noticed that I branched from my other changes. Should I remove those changes from this PR?

@dougwilson I rebased and cut out the extra commits.

Right, tests are of course failing, because the http2 module doesn't exist in previous versions. D'oh. I'll add a try catch around the require, thus only running http2 tests when...

Right, now the tests pass, but the travis config doesn't have node v9 in it, so no http2 tests are run there. Am I allowed to just add that? Edit:...

There is one warning node currently gives when using http2: (node:4065) ExperimentalWarning: The http2 module is an experimental API. As far as I can tell neither [v8.8](https://travis-ci.org/expressjs/compression/jobs/329139864) nor [v9.4](https://travis-ci.org/expressjs/compression/jobs/329139865) show...

> Can you verify that you ran every test suite of even dependency of this module throughout the tree with Node.js 9.x as well to check this? Do you mean...

Hm, not sure why the tests are suddenly failing on Travis. Works fine locally with 9.4 and worked fine on Travis before merging the master to resolve the conflicts.