Dist folder needs to be deleted prior to deploy

[paulfalgout]

create mode 100644 images/logos/stubhub.gif create mode 100644 images/logos/stubhub.png

That gif file doesn't exist anymore, and there are other files not in existence still getting deployed.

[samccone]

:+1:

[samccone]

@paulfalgout wait maybe I did not follow 100% as to what this issue was for.. care explaining a bit more

[paulfalgout]

So if I don't manually delete my dist folder before running npm run deploy it will get all of the files from previous compiles. So like my deploy the other night deployed gif files that were no longer in the repo, such as the stubhub.gif. So I missed that those two logos were broke, because running locally and on prod they worked just fine.

[jdaudier]

BTW, whenever I pull down the latest master, I always have to delete my dist folder in order to have the site launch properly for some reason. Not sure if it's related to this.

[paulfalgout]

so I think what it is clean:dist is only run with grunt dev so if I make a bunch of changes and deploy after running grunt dev dist doesn't get cleaned up.

[jdaudier]

meaning, the deployed files in dist are conflicting with what i should be seeing in dist during dev?

[paulfalgout]

so dist is a generate directory, mostly copied stuff from src. The dist file gets deleted when you run grunt dev, but if you delete a file from src/ and don't run grunt dev again, that file will remain in dist/ since the folder is never removed. So I'm not entirely sure what npm deploy is doing , but I don't think it's running clean:dist first, and it should.

[jdaudier]

ping @trezy :arrow_heading_up:

[samccone]

gotcha! np np

[trezy]

We probably just need to set up separate clean tasks for each build step - e.g. Sass, Jade, copy assets, etc.

[samccone]

yeeeeep simple simple fix