marionettejs.com icon indicating copy to clipboard operation
marionettejs.com copied to clipboard

Add IDs to sections for easy reference

Open trezy opened this issue 9 years ago • 7 comments

One of my coworkers asked my yesterday who actually uses Marionette. I just referred him to the list of the bottom of the website but I would rather have been able to send him a link like [http://marionettejs.com/#logos].

trezy avatar May 26 '15 13:05 trezy

:+1: But on small screens there will be a hidden trap - the navigation will work (they user will be navigated) but this specific section is hidden on mobile screens. So if section is to be bookmarkable it has to be accessible. /cc @jdaudier

peterblazejewicz avatar May 26 '15 18:05 peterblazejewicz

@peterblazejewicz Meaning we have to un-hide it for mobile, correct? Just making sure I am on the same page.

thanks @trezy for the idea! I'll see you tomorrow at JSConf.

jdaudier avatar May 27 '15 02:05 jdaudier

@jdaudier Yes, just make sure that any header/section with added bookmarkable anchor is visible on all viewports :D

peterblazejewicz avatar May 27 '15 18:05 peterblazejewicz

you got it!

jdaudier avatar May 28 '15 00:05 jdaudier

@peterblazejewicz I disagree. I've verified on several mobile devices -- Android 4.something, Android 4.somethingElse, iOS8, etc -- that the browser just brings you to the top of the homepage if the section is hidden. No unexpected consequences. I'll dig in and add these this weekend since I got the repo to build this time. :-)

trezy avatar Jun 29 '15 17:06 trezy

@trezy that's the point - user arepointed nowhere: http://bradfrost.com/blog/post/five-responsive-web-design-pitfalls-to-avoid/

don’t penalise users for the device they happen to be browsing with.

peterblazejewicz avatar Jun 29 '15 18:06 peterblazejewicz

@peterblazejewicz That's an issue with us hiding sections. If you're concerned with users being penalized then we should make sure all of the sections are available, i.e. not hidden from mobile. That's a completely separate issue. This is an enhancement to make the page more navigable for those that have the capability.

trezy avatar Jun 29 '15 18:06 trezy