marionette.inspector icon indicating copy to clipboard operation
marionette.inspector copied to clipboard

undefined ES5 getters/setters broken again

Open jklmli opened this issue 9 years ago • 3 comments

https://github.com/marionettejs/marionette.inspector/commit/8b35f9d5cf1626331243044d01a421095dd94891 overrode some of the fixes committed in https://github.com/marionettejs/marionette.inspector/commit/e869f18d13c636cd5d513cf30a189e38b1431f31

jklmli avatar Jun 02 '15 20:06 jklmli

Hmm.. I think some commenting is in order to prevent this from happening again. Or is there anyway we could accurately test this? Failing tests would be even better. Otherwise I could certainly see this happening again.

paulfalgout avatar Jun 05 '15 00:06 paulfalgout

Hmm, yea please submit a fix and comments or tests

jasonLaster avatar Jun 16 '15 20:06 jasonLaster

Anyone knows how to reproduce the issue, so i can add tests? @jiaweihli

blikblum avatar Jul 01 '17 15:07 blikblum