backbone.syphon icon indicating copy to clipboard operation
backbone.syphon copied to clipboard

remove lodash from peerDependencies

Open paulovieira opened this issue 8 years ago • 3 comments
trafficstars

package.json has lodash as a peerDependency. What's the reason for that? Backbone.Syphon doesn't use it anywhere in the application code.

paulovieira avatar Feb 03 '17 10:02 paulovieira

Hi @paulovieira

Syphon uses either lodash or underscore. I've left both in for now, though I'm happy for you to submit a PR if you have a preference for how it should be set up.

scott-w avatar Feb 03 '17 13:02 scott-w

Hi Scott! I'm a bit confused. I see syphon using only lodash (in the build file), and no sign of lodash:

https://github.com/marionettejs/backbone.syphon/blob/master/lib/backbone.syphon.js#L15

paulovieira avatar Feb 03 '17 13:02 paulovieira

Ahh, yeah it's done at the build file level. For example, in webpack, you can swap out underscore for lodash when you configure the imports.

scott-w avatar Feb 03 '17 13:02 scott-w