Mário Nunes
Mário Nunes
Thanks for the notes @benfurber The main reason to remove this aggregation is that we can build the same functionality without it, just need an extra profile field which is...
I've updated the description to better reflect what this PR does. > 1. Is our e2e coverage really good enough that no changes are needed? > 2. I've tried to...
Thanks, I've updated accordingly.
hmm ideally there should be a conditional when calling the method `capitalizeFirstLetter(word || '')` as it already only accepts `string`, not `undefined` or `null`. Improving our usage of typescript should...
Sorry I wasn't clear. I meant to say that your first changes shouldn't be necessary, because `capitalizeFirstLetter` only accepts a string already, not null/undefined. The root cause is likely somewhere...
> It seems that the `SortFilterHeader` component doesn't read the URL `category` parameter. I think this should be solved in a different issue/PR. what do you think? `SortFilterHeader` will be...
This PR needs a rebase/squash to remove extra commits as we use them for release notes. I've been using these steps to do it: https://stackoverflow.com/questions/30136558/how-to-squash-commits-which-have-merge-commit-in-between/69827502#69827502 And hopefully CircleCI doesn't randomly...
We could have less coupling if each module would use `` directly and generate it's own steps. So in practice Howto.tsx, ResearchArticle.tsx and QuestionPage.tsx would have their own generate steps...
Sure, the wrapper is not a blocker for me
it's just missing that `key`, then ready to merge