MHVideoPhotoGallery icon indicating copy to clipboard operation
MHVideoPhotoGallery copied to clipboard

Published 20 hours ago • verified publisher icon mariohahn

Thumbnail youtube video

Open dpizzuto opened this issue 9 years ago • 12 comments

When I load the photogallery with correct youtube item, the thumbnails inside gallery have grey image and length of 00:00 sec. Vimeo's video haven't this issue. Is it a known issue ?

dpizzuto avatar Jun 24 '15 09:06 dpizzuto

maybe its because the youtube v2 is deprecated. https://github.com/mariohahn/MHVideoPhotoGallery/issues/95

mythodeia avatar Jun 24 '15 09:06 mythodeia

I saw that actually there isn't a workaraound for fix this issue, right ?

dpizzuto avatar Jun 24 '15 09:06 dpizzuto

as far as i know not yet

mythodeia avatar Jun 24 '15 09:06 mythodeia

I saw one implementing V3. But i can't find it now :(

mariohahn avatar Jun 24 '15 10:06 mariohahn

I'll try to find out the new v3 api. I'll let you know. Please, keep this issue opened.

dpizzuto avatar Jun 24 '15 10:06 dpizzuto

I found a solution: I had to integrate new v3 api with api key and new URLs. For now, I adapted the code for my goals that are thumbnail and video duration. As soon as possibile, I'll fork your project and push the new code with pull request. Keep issue opened until I finish the operations.

dpizzuto avatar Jun 27 '15 15:06 dpizzuto

:+1: This PR fixed the same issue that I was having. Hopefully something with this gets pulled into the master repo.

Although it does seem a little funny to have to edit one of the Pod files (MHGallery.m) to add your API key. Is it possible to load this value from plist value instead?

chrismeats avatar Jul 07 '15 13:07 chrismeats

I don't like both of this ways... Maybe something have like this a just a Property:

extern void MHGalleryCustomLocalizationBlock(NSString *(^customLocalizationBlock)(NSString *stringToLocalize));

mariohahn avatar Jul 07 '15 13:07 mariohahn

Yes Chris, isn't the best solution so far but was, as described, a quick & dirty solution for my purpose. A good way, in my opinion, maybe to have a property to set in a SharedObject.

dpizzuto avatar Jul 07 '15 13:07 dpizzuto

property would be the best (:

mariohahn avatar Jul 07 '15 14:07 mariohahn

I went ahead and took a stab at this using MHGalleryCustomLocalizationBlock.

chrismeats avatar Jul 07 '15 15:07 chrismeats

Guys, does app support all possible youtube urls for downloading thumbnails and playing video? I found an issue with urls: "http://youtu.be/Jmb7NgNouoM" or "https://www.youtube.com/embed/DheulkmtR7Y?vq=hd720&rel=0&showinfo=0&modestbranding=1&enablejsapi=1&origin=http%3A%2F%2Fwww.shyp.com"

BTW the same issue with Vimeo for link: "https://player.vimeo.com/video/99743076?api=1"

okulak avatar Nov 17 '15 10:11 okulak