swift-package-info icon indicating copy to clipboard operation
swift-package-info copied to clipboard

Add support for custom xcconfig file

Open mackoj opened this issue 5 months ago β€’ 10 comments

fix #48

This pull request enables users to specify a custom XCConfig file, providing enhanced control over how project configuration influences its size.

For instance, by including --xcconfig test.xcconfig along with the following file, users can gain insights into the impact of specific settings on project size, such as the generation of Assets.car.

ASSETCATALOG_COMPILER_OPTIMIZATION = space

For further information on XCConfig files:

mackoj avatar Feb 06 '24 15:02 mackoj

Hi @marinofelipe,

I just wanted to let you know that I don't plan to pursue this matter further. If you see fit to integrate it into your project, feel free to make any changes necessary.

Best regards,

mackoj avatar Feb 06 '24 15:02 mackoj

Hi @marinofelipe,

HI @mackoj, first of all thanks for the contribution. I'll take some time to review it later.

In general, I really like the idea, build/linker settings and build optimisations definitely influence the binary size. The goal so far was for the project to give a close estimation, this could be great for a more precise reportπŸ‘Œ.

I just wanted to let you know that I don't plan to pursue this matter further. If you see fit to integrate it into your project, feel free to make any changes necessary.

Best regards,

Ok, I'd be happy to have you further contribute to it, but that's up to you πŸ˜„

marinofelipe avatar Feb 06 '24 16:02 marinofelipe

Ok, I'd be happy to have you further contribute to it, but that's up to you πŸ˜„

Thanks, it's just that I know I won't be able to follow through quickly due to time constraints, so I don't want to hinder the evolution of swift-package-info.

mackoj avatar Feb 06 '24 17:02 mackoj

Ok, I'd be happy to have you further contribute to it, but that's up to you πŸ˜„

Thanks, it's just that I know I won't be able to follow through quickly due to time constraints, so I don't want to hinder the evolution of swift-package-info.

Thank you, but It's all good, I myself also struggle to find time for it πŸ˜…

marinofelipe avatar Feb 09 '24 16:02 marinofelipe

Gentle ping @marinofelipe this is just in case you forgot about this PR.

mackoj avatar Feb 20 '24 00:02 mackoj

Hi @mackoj, I didn't 😊. The says were quite busy, I'll get back to it later this week

marinofelipe avatar Feb 20 '24 20:02 marinofelipe

Heads up @mackoj , I'm gonna check this PR this weekend.

marinofelipe avatar Mar 16 '24 15:03 marinofelipe

Thanks for the review @marinofelipe I'll try to find time to implement your feedback this week.

mackoj avatar Mar 20 '24 08:03 mackoj

Hi @marinofelipe, I did integrate your feedback.

mackoj avatar Mar 29 '24 14:03 mackoj

Hi @marinofelipe, I did integrate your feedback.

Nice, thanks again for your contribution @mackoj, this is a great addition πŸš€ ! This will go to the next release, alognside #47 πŸ™Œ

marinofelipe avatar Mar 31 '24 21:03 marinofelipe