marimo icon indicating copy to clipboard operation
marimo copied to clipboard

Ctrl+shift+P keyboard shortcut conflicts with Firefox "open private window"

Open mgunyho opened this issue 1 year ago • 1 comments

Describe the bug

I'm just starting out with marimo, and it's looking pretty nice so far! However, I noticed that the keyboard shortcut for "create cell below" is ctrl+shift+P, which in Firefox opens a private/incognito window. So I am unable to use this shortcut, even though it's something I would like to do often. I couldn't see a way to customize the shortcuts.

As a workaround, I usually go to a cell below the current one and create a new above it using ctrl+shift+O.

Environment

{
  "marimo": "0.3.3",
  "OS": "Linux",
  "OS Version": "5.15.0-100-generic",
  "Processor": "x86_64",
  "Python Version": "3.8.10",
  "Binaries": {
    "Chrome": "123.0.6312.58",
    "Node": "--"
  },
  "Requirements": {
    "black": "24.3.0",
    "click": "8.1.7",
    "jedi": "0.19.1",
    "pygments": "2.17.2",
    "pymdown-extensions": "10.7.1",
    "starlette": "0.37.2",
    "tomlkit": "0.12.4",
    "uvicorn": "0.29.0"
  }
}

mgunyho avatar Mar 21 '24 08:03 mgunyho

We've been meaning to add shortcut customization. If your workaround is too much trouble, we could special case this shortcut on firefox (would you have a preferred key combination?)

akshayka avatar Mar 21 '24 17:03 akshayka

using ctrl+shift+O.

Well, it does not work for me… Ctrl+Shift+O opens the bookmark window here.

would you have a preferred key combination?

I have no preference. Jupyter uses Esc, A/B, Enter, but that's a totally different logic.

There are only 4 compatible letters for Ctrl+Shift+❓: F, L, U, Y. So overriding might be inevitable.

Useful links:

YDX-2147483647 avatar May 22 '24 04:05 YDX-2147483647