marimo icon indicating copy to clipboard operation
marimo copied to clipboard

Fix: html-wasm export prompted an overwrite

Open swapnilbehere opened this issue 1 month ago • 4 comments

📝 Summary

Fixes #6012

🔍 Description of Changes

The issue prompted an index.html overwrite whenever an index file is not provided. This lead to a bug where export_assests() exported everything including index.html, which was then overwritten by watch_and_export() to store the actual content.

My fix: The flag "ignore_index_html" should always be true when exporting as html-wasm.

📋 Checklist

  • [X] I have read the contributor guidelines.
  • [ ] For large changes, or changes that affect the public API: this change was discussed or approved through an issue, on Discord, or the community discussions (Please provide a link if applicable).
  • [ ] I have added tests for the changes made.
  • [X] I have run the code and verified that it works as expected.

swapnilbehere avatar Nov 03 '25 23:11 swapnilbehere

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
marimo-docs Ready Ready Preview Comment Nov 3, 2025 11:40pm

vercel[bot] avatar Nov 03 '25 23:11 vercel[bot]

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

github-actions[bot] avatar Nov 03 '25 23:11 github-actions[bot]

I have read the CLA Document and I hereby sign the CLA

swapnilbehere avatar Nov 03 '25 23:11 swapnilbehere

Hmm, I don't think this is totally correct- but running the tests to see what fails. Thank you though!

dmadisetti avatar Nov 03 '25 23:11 dmadisetti