marimo
marimo copied to clipboard
Slow VIM keymaps in marimo notebook
Describe the bug
I think this is related to the size of my notebook but in one of my notebooks, vim keymaps are very slow. I press "I" for insert and it takes 3 seconds to enter insert mode. I don't feel anything different when operating in insert mode though. Anyone else noticed that?
Environment
{ "marimo": "0.9.32", "OS": "Linux", "OS Version": "4.18.0-553.27.1.el8_10.x86_64", "Processor": "x86_64", "Python Version": "3.11.10", "Binaries": { "Browser": "--", "Node": "--" }, "Dependencies": { "click": "8.1.7", "docutils": "0.19", "itsdangerous": "2.2.0", "jedi": "0.19.1", "markdown": "3.6", "narwhals": "1.13.2", "packaging": "24.0", "psutil": "5.9.8", "pygments": "2.18.0", "pymdown-extensions": "10.8.1", "pyyaml": "6.0.1", "ruff": "0.5.6", "starlette": "0.37.2", "tomlkit": "0.12.5", "typing-extensions": "4.12.1", "uvicorn": "0.30.1", "websockets": "12.0" }, "Optional Dependencies": { "altair": "5.3.0", "duckdb": "1.1.2", "pandas": "2.2.2", "polars": "1.12.0" } }
Code to reproduce
No response
I think because we update the "mode" across all editors and that may set/unset listeners and cause re-renders. We can look into optimizing.
@lborcard ~~are you still experiencing this issue? we've made some other rendering optimizations, so maybe this has gone away. i cannot reproduce it myself~~
actually the sync was regressed at some point, but i did find a fix that should help with some perf for this
@lborcard ~~are you still experiencing this issue? we've made some other rendering optimizations, so maybe this has gone away. i cannot reproduce it myself~~
actually the sync was regressed at some point, but i did find a fix that should help with some perf for this
thank you for the fix I indeed did not experience again. although I also try to keep my NBs shorter. thanks for the work.
@lborcard ~~are you still experiencing this issue? we've made some other rendering optimizations, so maybe this has gone away. i cannot reproduce it myself~~
actually the sync was regressed at some point, but i did find a fix that should help with some perf for this
thank you for the fix I indeed did not experience again. although I also try to keep my NBs shorter. thanks for the work.