marimo icon indicating copy to clipboard operation
marimo copied to clipboard
verified publisher icon marimo-team

fix: lsp port selection

Open akshayka opened this issue 1 year ago • 3 comments

Fixes #2435

akshayka avatar Sep 28 '24 04:09 akshayka

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
marimo-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 28, 2024 2:54pm
marimo-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 28, 2024 2:54pm

vercel[bot] avatar Sep 28 '24 04:09 vercel[bot]

the fronted needs to know this port as well

mscolnick avatar Sep 28 '24 12:09 mscolnick

I think if we make this refactor, we could change <marimo-server-token to <marimo-server-config that is a dictionary of token, lsp-port, and other config that i can see us needing to add in future.

mscolnick avatar Sep 29 '24 15:09 mscolnick

Thanks to @maxtheman, we know have some code/utils to proxy requests from our main server (https://github.com/marimo-team/marimo/pull/2897). I think it could be worthwhile to use this to proxy to our LSP server instead of passing the port to the frontend

mscolnick avatar Nov 20 '24 16:11 mscolnick