marimo icon indicating copy to clipboard operation
marimo copied to clipboard

data table not updating properly anymore after pagination [regression]

Open proycon opened this issue 1 year ago • 9 comments

Describe the bug

We (@dirkroorda and I) found a regression in the display of polars dataframes in mo.ui.table. After pagination, the table is no longer responsive to changing input. (see code to reproduce). We think the problem was introduced in v0.8.4, probably in #2115 . At least versions v0.7.7 to v0.8.3 do have the expected behaviour.

Environment

{
  "marimo": "0.8.11",
  "OS": "Linux",
  "OS Version": "6.10.7-arch1-1",
  "Processor": "",
  "Python Version": "3.12.5",
  "Binaries": {
    "Browser": "--",
    "Node": "v22.8.0"
  },
  "Dependencies": {
    "click": "8.1.7",
    "importlib-resources": "missing",
    "jedi": "0.19.1",
    "markdown": "3.6",
    "pygments": "2.18.0",
    "pymdown-extensions": "10.8.1",
    "ruff": "0.5.2",
    "starlette": "0.37.2",
    "tomlkit": "0.13.0",
    "typing-extensions": "missing",
    "uvicorn": "0.30.1",
    "websockets": "12.0"
  },
  "Optional Dependencies": {
    "pandas": "2.2.2",
    "polars": "1.2.0"
  }
}

We also tested three different browsers (firefox, safari, chromium) and on both Linux and on mac.

Code to reproduce

The problem is apparent in this notebook: https://github.com/knaw-huc/brieven-van-hooft-notebook , steps to reproduce are:

  1. marimo run the notebook (starting it may take a while because of data download)
  2. In the section Exploring vocabularies, change the field datakey. You see the table below updates accordingly, do this a few times without doing anything else to see the intended behaviour.
  3. Now select datakey = recipient and navigate to page 2 in the table.
  4. Change the data key to something else again, the table now no longer updates! (this is the bug since v0.8.4, prior versions worked fine)

proycon avatar Sep 05 '24 11:09 proycon