Midje icon indicating copy to clipboard operation
Midje copied to clipboard

background prerequisites should obey :times

Open marick opened this issue 12 years ago • 3 comments

Right now, a background prerequisite always is implicitly tagged with :times (range 0). If a user explicitly specifies a :times, that should be obeyed.

marick avatar Apr 24 '12 16:04 marick

I'm disliking this idea now. For a provided prerequisite, it's clear where the how-many-times-called check happens. When does the check for a wrapping background check happen? At exit from the fact? I think the complexity is unwarranted for a feature not-that-often used.

marick avatar May 10 '12 19:05 marick

I'm consolidating all these "background" features into one report that will serve as a reference for the rewrite.

marick avatar Jan 16 '13 00:01 marick

Reopening because I think it is worth looking into addressing.

I've seen some tests that use :times with against-background, which basically doesn't do anything, so it would be good to get this sorted to prevent confusion and make sure tests are checking what they expect to check

If going for a fix of this behavior, worth looking at https://github.com/marick/Midje/issues/54 as well

philomates avatar Nov 13 '17 16:11 philomates