marian-dev icon indicating copy to clipboard operation
marian-dev copied to clipboard

Update Catch2 from 2.10.1 to 2.13.9

Open graemenail opened this issue 2 years ago • 0 comments

Description

This PR updates Marian to use the most recent version of Catch2 in its v2 series of releases.

I encountered a compilation issue on a Ubuntu 22.04 machine with gcc-11. The issue was from a glibc change (between 2.31 -- 2.35) in which a system call can no longer be constexpr. See the related issue for more details.

This is already patched in newer Catch2 versions.

Related: https://github.com/catchorg/Catch2/issues/2178, #958

List of changes:

  • Update Catch2 header

Added dependencies: none

How to test

  • Changes compile on impacted system, and non-impacted systems.
  • Unit tests run and pass.
  • GitHub actions (including unit tests) pass.

Checklist

  • [x] I have tested the code manually
  • [ ] I have run regression tests
  • [x] I have read and followed CONTRIBUTING.md
  • [x] I have updated CHANGELOG.md

graemenail avatar Jun 07 '22 12:06 graemenail