Maria Grimaldi (Majo)

Results 272 comments of Maria Grimaldi (Majo)

I'll close this since the actual issue was solved. I also opened a new one for the improvement left.

I don't have access to an e-commerce installation, so I can't test this to confirm the issue. @sambapete can you lend us a hand here? Thanks! Also, if you think...

Thanks for fixing this issue. Now, I'd like to know the performance impact this could have in the long run. Have you folks tested this with a more significant volume...

@GlugovGrGlib: As you mentioned, if merged to quince.master, it won't be included in a new release. But folks could still use quince.master branch. If that works for you, I could...

@Inferato @GlugovGrGlib: can we close this PR in favor of #34584?

Hi folks. I'm tagging you in our official technical proposal for connecting teams to content groups since you were tagged in the 1st rough implementation of the feature: https://github.com/openedx/edx-platform/pull/32806#issuecomment-1648264648 FYI...

Just so you know, the tests are failing because of the query count, so I'll leave them be until we have a review and I hear what you think about...

Hi @kdmccormick! Thank you for the feedback and the patience; I'll address your comments ASAP. :)

We understand how difficult it can be to set up a testing environment to review specific pull requests, so we'll add access information to the installation where we've been testing...

@BryanttV: thank you for the report! I'll be looking into it.