react-native-quick-crypto icon indicating copy to clipboard operation
react-native-quick-crypto copied to clipboard

Switch to prebuilt openssl binaries

Open GNUGradyn opened this issue 1 year ago • 1 comments

Hello. as discussed on Discord, building for Android (at least on Windows) is currently broken due to the openssl prefab being broken. I've reported this to Google (https://issuetracker.google.com/issues/341136039). In the mean time, I am suggesting we include the OpenSSL binaries. These are 1.1.1u binaries because modern OpenSSL is not backwards compatible this far. I've also built some 3.2.1 binaries and I'll include those in an issue. Here is the script I wrote to build openSSL in case you want to audit it and compare my binaries to the result https://gist.github.com/GNUGradyn/50ed6a4b09fc744097fcef6140f4e826

GNUGradyn avatar May 17 '24 15:05 GNUGradyn

Yeah, I checked this PR out as well, and I'm not feeling it. Not sure what to do here to help you out.

I did see a random old (ish) version of NDK in the library's gradle rig, but I don't think it was getting set/used due to a bug I introduced. Maybe try specifying ndkVersion in your local.properties file? i.e. ndkVersion = "25.1.8937393" or maybe the fix is to have a snippet like this in build.gradle:

  defaultConfig {
    ...
    ndkVersion safeExtGet('ndkVersion', '25.1.8937393')
    ...

boorad avatar May 21 '24 01:05 boorad