react-native-graph icon indicating copy to clipboard operation
react-native-graph copied to clipboard

hot swap skia useValue and runSpring hooks with standard reanimated ones

Open daxaxelrod opened this issue 4 months ago • 3 comments

Need a second pair of eyes here. Got everything to compile but having trouble when testing locally. I git cloned the repo and then used npm link to install it locally in another project as a testing ground (also modified metro, thats project references work just fine).

I keep getting a _measure is undefined error which tells me that the babel worklet plugin is not working. Also when I comment out props.animated in src/LineGraph.tsx to just render the static line component, it throws a couple of react errors which I know shouldnt be happening: Invalid hook call, Hooks can only be called in the body of a function and cannot read property 'useState' of null.

Any ideas? SO and gpt came up dry. How did you test the lib locally @mrousavy

daxaxelrod avatar Feb 14 '24 02:02 daxaxelrod

Hey, thanks for your PR!

To test it locally just run the example/ app here.

mrousavy avatar Feb 14 '24 09:02 mrousavy

Thanks, not working quite right yet, will do more testing over the weekend

daxaxelrod avatar Feb 14 '24 17:02 daxaxelrod

Any luck with fixing the example? Running into this in project too :(

vovacodes avatar Feb 23 '24 20:02 vovacodes

Hello! Are there any updates on this PR?

dsshard avatar Mar 12 '24 10:03 dsshard

@mrousavy this PR is not needed anymore since the migration was done

gabimoncha avatar Mar 12 '24 13:03 gabimoncha

yup 👍

mrousavy avatar Mar 12 '24 13:03 mrousavy

released in latest version on npm

mrousavy avatar Mar 12 '24 13:03 mrousavy