react-native-graph icon indicating copy to clipboard operation
react-native-graph copied to clipboard

Feat: Indicator

Open chrispader opened this issue 3 years ago • 7 comments

Allow the user to show an indicator at the end of the graph. This indicator gets hidden once the hold/pan gesture gets started.

chrispader avatar Jun 13 '22 09:06 chrispader

@mrousavy Ready for review! This PR is based on #17 and #18.

chrispader avatar Jun 13 '22 09:06 chrispader

@chrispader do you have a video example of what the indicator looks like? Wondering what the use case would be!

gtokman avatar Jul 02 '22 21:07 gtokman

This is how it looks in the app i originally had the need for this feature.

This includes the basic indicator and also a "live" pulse animation.

https://user-images.githubusercontent.com/20173411/177016519-4513ee97-0bf8-4bc8-ac5d-2ed005638ecb.MOV

chrispader avatar Jul 02 '22 21:07 chrispader

Not completely finished yet though 😬

chrispader avatar Jul 02 '22 21:07 chrispader

@chrispader the live pulse looks super nice!

gtokman avatar Jul 04 '22 17:07 gtokman

Have you tried integrating a gradient?

Saw some discussion here https://github.com/margelo/react-native-graph/issues/11#issuecomment-1119861429.

gtokman avatar Jul 04 '22 17:07 gtokman

Not yet! Implemented a lot of features for use cases in one of our own projects at Margelo. I'll talk to @mrousavy on this. If i find some time, i may be implementing this for general use.

chrispader avatar Jul 18 '22 09:07 chrispader

Hey Chris Pader, I was playing around with the Spline interpolation method you integration in this PR. I think it might not be implemented correctly, as there were a few of my datapoints with higher Y positions, got rendered lower

Leoputera2407 avatar Aug 31 '22 19:08 Leoputera2407

Hey Chris Pader, I was playing around with the Spline interpolation method you integration in this PR. I think it might not be implemented correctly, as there were a few of my datapoints with higher Y positions, got rendered lower

Hi! Thanks for your input.

I already made some changes in a project for one of our clients, that address these issues..

I'll update this PR soon, so everhing works.

Sorry for the delay, kinda busy right now 😅😬

chrispader avatar Aug 31 '22 20:08 chrispader

No worries, thanks for working on this! I have been trying to fix the interpolation issue as well. The current bezier curves only results in such blocky graphs when data is sparse.

Leoputera2407 avatar Aug 31 '22 23:08 Leoputera2407

@chrispader, are there any updates on this?

Leoputera2407 avatar Sep 06 '22 05:09 Leoputera2407

Not supposed to be closed, just an issue with squashing the commits. To be continued

chrispader avatar Sep 06 '22 09:09 chrispader

LGTM! 🚀 nice work chris!

mrousavy avatar Sep 08 '22 10:09 mrousavy