react-native-bignumber icon indicating copy to clipboard operation
react-native-bignumber copied to clipboard
verified publisher icon margelo

fix: Add C++17 support

Open dexterslabor opened this issue 1 year ago • 3 comments

Closes #69

dexterslabor avatar Sep 25 '24 17:09 dexterslabor

Thanks for your PR, but what doesn't work without it?

mrousavy avatar Sep 30 '24 18:09 mrousavy

Thanks for your PR, but what doesn't work without it?

hi @mrousavy, we also faced the same issue which this PR fixes. Without this patch, we are unable to build the app on RN 0.75 + Expo 51. I added more details and stack trace on the issue here - https://github.com/margelo/react-native-bignumber/issues/69#issuecomment-3166758238

It will helpful if you can look into it and merge it if it looks good. I'm unsure if c++17 or c++20 would break anything in the library, but the app got built successfully for me on c++20

ayush-leap avatar Aug 08 '25 07:08 ayush-leap

Hi, same issue here @mrousavy , using react-native-bigumber 0.3.0 and RN 0.75.5 image

This PR solves the issue

emenocal07 avatar Sep 26 '25 16:09 emenocal07