imagelightbox icon indicating copy to clipboard operation
imagelightbox copied to clipboard

No settimeout

Open paxperscientiam opened this issue 6 years ago • 2 comments
trafficstars

Depending on what you decide WRT support (see PR #180 ), this PR allows for one settimeout to be dropped in favor of transitionend detection.

paxperscientiam avatar Dec 12 '18 05:12 paxperscientiam

Wanted to merge this into develop, but then a new glitch appears: I clicked through the demo gallery (latest chrome browser) and when the second round starts some images come from the bottom up instead from the right.... Can you confirm?

rejas avatar Dec 19 '18 09:12 rejas

I'll check this out today. Gotta download Chrome

paxperscientiam avatar Dec 19 '18 18:12 paxperscientiam

Hi, @paxperscientiam, I've made a lot of changes to the code recently, so it was easier to recreate this PR from scratch in #892 - however, it doesn't work for me :( Could you take a look, please?

Closing this PR, you should have write access, so feel free to use #892 instead :) Thanks!

marekdedic avatar Mar 03 '24 21:03 marekdedic