marekdedic
Flash an indicator for fullscreen
When fullscreen is possible, a message should flash or otherwise indicate to user that the enter key will toggle fullscreen mode.
Good point @GenaBitu. Also, most browsers already show some message when fullscreen is triggered. So I am closing this issue.
Oh, I don't think it was meant as a message when fullscreen is triggered - I think it was meant as a message kind of like "You can press Enter to enter fullscreen" when the lightbox is opened, because otherwise most user won't know about the option to do so.
Oh, I don't know about an icon, but maybe it could work if done well. I was kind of imagining something like a floating caption in the bottom right corner that disappears after n seconds...
Right now I have other projects to focus on so I leave this issue open but wont do it myself. If somebody comes up with a good mockup, I'd reconsider this (dont do a PR before a design/idea is formulated). But normally your page should show this hint and not the library.
I'm on the, but IIRC there is a pretty widely accepted icon for indicating fullscreen
On Mon, Jun 4, 2018, 5:15 AM Veeck [email protected] wrote:
Right now I have other projects to focus on so I leave this issue open but wont do it myself. If somebody comes up with a good mockup, I'd reconsider this (dont do a PR before a design/idea is formulated). But normally your page should show this hint and not the library.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/rejas/imagelightbox/issues/129#issuecomment-394288168, or mute the thread https://github.com/notifications/unsubscribe-auth/AHMMnybhLct0GSYS9Zwj9OiIpyRfOorMks5t5PqngaJpZM4OZW6G .
http://fontello.com/#search=fullscreen Maybe in combination with https://www.iconfinder.com/icons/2961578/computer_device_enter_key_keyboard_return_icon#size=256
Well, there are icons for fullscreen indeed but those are for clicking on it, not for signalling "hey, press enter to go fullscreen" And showing two icons sidebyside (icon_fullscreen)(icon_enter_key) seems convoluted to me....
Ok, why not go the simple route and instead of a fullscreen hint add a fullscreen button?
My idea would be either in the bottom right of the image or in the bottom right of the screen. (That's purely subjective though...) Also I think the idea of the button disappearing after some timeout might also make sense here (especially if the button would be over the image...)