Marcus Efraimsson

Results 111 comments of Marcus Efraimsson

Should re-gen protobuf I think before/if merging this

Regarding "We should add methods/options that add error source, but will not override it if it exists". @ivanahuckova https://github.com/grafana/grafana-plugin-sdk-go/pull/1106#discussion_r1795449882: > Do we want to have a similar logic here from...

Reg "Deprecate experimental/errorsource and point plugin developers use non-experimental versions of functions." and "We should probably export errorWithSourceImpl and use it in experimental/errorsource instead of Error to ensure that all...

> I think a first step (before adding the API version to protobuf), would be to decide what would be the origin (source of truth) for this API version. Would...

Can you give an example where you would use this code, something you can link to?

Some additional thoughts regarding variables and timezones https://github.com/grafana/support-escalations/issues/11969#issuecomment-2331365821

Since there's been some development, you might want to add your logic to https://github.com/grafana/grafana-plugin-sdk-go/blob/0afdd23fd2176aead359ec566c9ae9151770b6a4/experimental/status/status_source.go#L134-L140 @ivanahuckova FYI

Think this should be redirected/moved to https://github.com/grafana/helm-charts

FYI I've forked this repository, converted to go modules and tagged v0.1.0 https://github.com/marefr/go-conntrack

FYI I've forked this repository, converted to go modules and tagged v0.1.0 https://github.com/marefr/go-conntrack. Planning to incorporate all the open PR's in my fork.