Marcus Read
Marcus Read
**TO REVIEW losing the right limit on `data.Data`** `data.Data.rl` (the right limit up to which data can be requested for a specific base interval) is currently set to 'now' +...
The 4.0 release failed to import as a result of not including the sub-packages in the build (#203). My bad, although it should have been picked up by the release...
Given that we have a list of Korean holidays hardcoded in, how would people feel about removing all of the Korean Lunar/Solar calendar stuff? The code's not thread-safe at initialisation...
The test [TestXKRXCalendar.test_feb_29_2022_in_lunar_calendar](https://github.com/gerrymanoim/exchange_calendars/blob/a9d8c5207471f22476337629140983aeba41b292/tests/test_xkrx_calendar.py#L132) results in 6 instances of the following deprecation warning: ``` ...\exchange_calendars\exchange_calendars\pandas_extensions\korean_holiday.py:76: DeprecationWarning: The truth value of an empty array is ambiguous. Returning False, but in future this...
Add coveragepy and github action to at least alert if coverage drops (raised originally by @gerrymanoim in #252)
_Originally posted by @gerrymanoim in https://github.com/gerrymanoim/exchange_calendars/issues/61#issuecomment-885372008_ I'd add - [ ] Real documentation My preference is probably some markdown backed sphinx system on github pages. @maread99 edit for specific documentation...
Because it blanket tests the edges of all sessions, the `test_prev_next_minute` is one of the slowest tests of the suite. The test could be sped up considerably by focusing on...
Hi @elbakramer, I'm migrating the calendar test modules to a new test base and XKRX is failing a new test that checks `late_opens` against late opens as [evaluated](https://github.com/gerrymanoim/exchange_calendars/blob/a5f2ca17fc4a9195bc56b4b783420b4e9b999fc5/tests/test_exchange_calendar.py#L2785) from the...
The max_adv evaluation can misinterpret a one day drop as the maximum advance if it's greater than the actual max advance - it sees the high / low and makes...