TypeError: r.getAllMarks

[channingwalton]

trafficstars

Obisidian version v0.13.0

Uncaught TypeError: r.getAllMarks is not a function
    at eval (eval at <anonymous> (app.js:1), <anonymous>:367:59524)
    at Y8.withCodeMirrorEditor (eval at <anonymous> (app.js:1), <anonymous>:367:60241)

[marcusolsson]

Thanks for reporting! I'll try to look into this later this week.

[kmaustral]

Same here on v0.13.6

[vincentteoh]

Same error message here.

[marcusolsson]

Seems like the API has changed in v13.x. I'll have time to look at this next week. Thanks for reporting this!

[marcusolsson]

I believe that once Obsidian 13 is officially released, it'll have a Legacy Editor option to support plugins that depend on features that haven't yet been made available to plugins in 13.x. I'll look for a proper fix, but at least the plugin will continue to work with the new option.

[marcusolsson]

I've added a Troubleshooting section in the README on how to enable the Legacy Editor for now.

[rushikb]

Hi Marcus! I'm a big fan of Vale— just wanted to check whether you still plan on supporting CM6 now that Obsidian 13 is officially released. This is such a phenomenal tool

[marcusolsson]

Hey! I'm definitely planning to upgrade the plugin. I haven't had the chance to look into it yet, but AFAIK the new Editor API has yet to achieve feature parity with CM5, and doesn't support markers yet. If there's a way to grab the CM6 instance somewhere, that might also work. If anyone knows how, I'd be happy to prioritize this. Otherwise, I'll try and find some time for this in the coming weeks.

[chrisgrieser]

yeah I came here to report the same thing – it seems the new editor is not supported :(

[marcusolsson]

@chrisgrieser Sorry 'bout that 🙏 I'll try and look into this next week.

[marcusolsson]

Just to give an update. I've been reading up on how to migrate from CM5 to CM6, and unfortunately there doesn't seem to be an easy fix to this.

If anyone want to experiment, here's the best resources I've found so far:

• CM6 example
• Extending CodeMirror
• Marked text

Seems like we'd need to build a CodeMirror extension rather than calling methods for adding marks.

I haven't given up on this, but right now this seems to require more time than I have at the moment. Seems like I need to read the CodeMirror docs more closely before I give this another try.

Thanks for the patience! 🙏

[eleanorkonik]

Thanks for including the experimentation tips! I'll include this in the Roundup :)

[mohitmujawdiya]

Hi! Thank you for creating such an awesome extension. While it works like a breeze in the legacy editor, I simply can't leave the features of the new editor like a live preview. Any update on this?

[marcusolsson]

Thank you @mohitmujawdiya! No updates unfortunately.

I definitely want to fix this, though I haven't yet found the time to work on it. I don't have any estimate on when I'll be able to.

[mohitmujawdiya]

hi Marcus! no problem, i'll wait. (will keep using linter and language tool plugins for now)

[Jayy001]

Hi there, any updates on this?