Marcus Müller

Results 470 comments of Marcus Müller

[I'd need to double check, but](https://github.com/gnuradio/gnuradio/blob/b554eeab2e70cad520d85dd190eac862cefc9bd0/gr-filter/lib/fft_filter.cc#L131) https://github.com/gnuradio/gnuradio/blob/b554eeab2e70cad520d85dd190eac862cefc9bd0/gr-filter/lib/fft_filter.cc#L131 looks very overlap-add to me, indeed.

It seems to be deterministically seeded: https://github.com/gnuradio/gnuradio/blob/main/gr-digital/python/digital/qa_constellation_receiver.py#L87-L92

> Since `string_view` doesn't control ownership, what happens when a PMT dict is created from some sort of temporary strings? Is this something the dev will need to be aware...

@willcode this *should* be backportable, question is whether you want!

Lol, [failing windows checkout](https://github.com/marcusmueller/gnuradio/runs/5630771867?check_suite_focus=true#step:2:780): ```text Error: error: cannot lock ref 'refs/remotes/origin/file_meta_sink_py3_vector': Unable to create 'D:/a/gnuradio/gnuradio/.git/refs/remotes/origin/file_meta_sink_py3_vector.lock': Invalid argument ``` Windows file system restrictions strike once more! (fixed by deleting the uninvolved...

> ~It would be backportable if the `make` in GRC used keywords. Otherwise, older versions of 3.10 would not be able to use newer GRC files.~ _no, that wouldn't work...

Good point! I'd try to stay "integer counter" internally/for the ctor, but offer alternative `make` signatures, one with the maximum number of items, but another convenience one that converts time...

@mormj I came at it from the Qt Time Sink side, where you do specify the number of samples. But let me quickly remedy that by simply introducing the steps...

@dkozel it is annoying, but I can't have a single backwards-compatible block; GRC doesn't support ignoring unknown parameters from a GRC file. So, I'll have at least two blocks (classic...

This still needs a test case and wiki page before of can be merged. C++ gen is completely untested!