Marcus Müller comments

Results 473 comments of


                                            Marcus Müller

Setting processor affinity of hier_block2 with message ports segfaults

Yeah, I think you found an infinite recursion; hm.

Setting processor affinity of hier_block2 with message ports segfaults

So, - I think it might be *correct* that `calc_used_blocks` contains the block itself in this situation; the `hier_block` itself is part of the (message) flowgraph - An easy solution...

Setting processor affinity of hier_block2 with message ports segfaults

This reaches far further: `calc_used_blocks` is *generally* unsafe to use in a recursive manner. At the very least, the following methods are also affected, as they call themselves on an...

Setting processor affinity of hier_block2 with message ports segfaults

hm, so, interestingly, the problem seems easily solvable through iteration through the flattened flowgraph (`flatten_aux` is our helper here) for the processor affinity – we don't set processor affinities for...

Setting processor affinity of hier_block2 with message ports segfaults

puuuuh `flatten_aux` is a side-effect carnival… Yeah, we'll have to implement that ourselves.

Setting processor affinity of hier_block2 with message ports segfaults

got a solution for this, needs some cleanup, will push later.

digital::fll_band_edge_cc::set_samples_per_symbol() is not thread safe

@geekyraghav13 well, you proposed what seems to be a reasonable change, so that's why we're encouraging you to send us your proposed patch in the shape of a pull request...

Small block size with tailbiting CC results in errors with no noise

yep, far as I can tell from the source, still there.

Small block size with tailbiting CC results in errors with no noise

would be high, but feeling is to fix a hoist of things with gr-fec, this would be rewritten inherently

Deprecating Clock Recovery MM

tagging as low prio, because this is only important for straightforward porting, and FGs using the deprecated block have gotten rare. Not a good "solution", but realistic…