mockdraftable-web icon indicating copy to clipboard operation
mockdraftable-web copied to clipboard

Add draft year to url

Open tbone849 opened this issue 5 years ago • 2 comments

I am trying to format and populate a list of your embedable URLs but I am having issues with some of the URL formatting. Sometimes if the name is a duplicate from past years, you add the year to the end of the name (https://www.mockdraftable.com/embed/zach-allen-2019?position=DL&page=MEASURABLES) and for others with duplicate names, you don't. It would be more helpful to simplify the URLs by draft year (https://www.mockdraftable.com/embed/2019/zach-allen?position=DL&page=MEASURABLES). That way you don't have confusion about who you are looking at either and it would be much easier to surmise URLs for any year.

tbone849 avatar Mar 13 '19 18:03 tbone849

Ah. Those aren't just URLs, actually, they're the player IDs (and this URL structure was designed quite intentionally, in an effort to maximize the readability of the urls in the general case). The first player with a given name will lack a year next to them. Additionally, the logic states that in the event of multiple players with the same name in the same year, I append a -2, -3, -4, etc.

marcusdarmstrong avatar Mar 13 '19 19:03 marcusdarmstrong

I get it, it just makes it more difficult because I have to check for names that I think might have a duplicate. If it was by year, the guess-work would be gone. You would probably have to change your whole system to account for it so I don't expect you to make any changes.

tbone849 avatar Mar 28 '20 15:03 tbone849