karma-remap-istanbul icon indicating copy to clipboard operation
karma-remap-istanbul copied to clipboard

1.0

Open mattlewis92 opened this issue 8 years ago • 7 comments

I think this module is relatively stable now, having a quick flick through the open issues it seems most of them are resolved by recently merged or outstanding PRs. There are a few more things I think we should do before putting a 1.0 label on the module

  • [x] review and merge outstanding PRs, then cut a 0.3.0 release with the new features + fixes
  • [x] review all open issues and close any that are now resolved by the new PRs
  • [x] setup tests (a couple of e2e that uses karmas API and mocks nothing would be best)
  • [x] setup eslint
  • [ ] setup travis that runs the tests and the linter
  • [x] add more examples (TS karma preprocessor, system.js, anything else??) -> both of these come with remap istanbul integrated
  • [x] upgrade remap-istanbul to latest -> waiting on 0.9.0 to land
  • [x] drop support for node 0.12 (at the end of the year)

cc @mateuszjuszkiewicz @delasteve

mattlewis92 avatar Dec 06 '16 11:12 mattlewis92

PRs:

  • https://github.com/marcules/karma-remap-istanbul/pull/19 can be merged once requested changes are made
  • https://github.com/marcules/karma-remap-istanbul/pull/20 can be deleted as issue should already be fixed by PR27

Issues:

  • https://github.com/marcules/karma-remap-istanbul/issues/26 - looks like it will be fixed when PR19 is merged
  • https://github.com/marcules/karma-remap-istanbul/issues/21 - is fixed by PR27

As for releases, should 0.2.2 be cut first and 0.3.0 after tests prove that upgrade to remap-istanbul to 0.7.0 doesn't cause any issues?

mateusz-j avatar Dec 06 '16 20:12 mateusz-j

@mateuszjuszkiewicz nice, thanks for doing that summary 👍

My thinking was to do a 0.3.0 release once #19 is merged (as it's a new feature which would be a minor bump according to semver). That will solve the immediate blockages for folks using this module. After that do the remap-istanbul upgrade, although it shouldn't be breaking according to the release notes

mattlewis92 avatar Dec 06 '16 22:12 mattlewis92

I tried to upgrade to remap-istanbul v0.7.x in angular-cli. However, it's incompatible.

e-cloud avatar Dec 07 '16 07:12 e-cloud

@marcules sorry to bother you, is there any chance you could enable this repo on travis? https://travis-ci.org/ Should only take < 1 min 😃

mattlewis92 avatar Dec 19 '16 09:12 mattlewis92

Hi, I'll look into it tomorrow.

Greetings, Marc

On Mon, 19 Dec 2016 at 10:57 Matt Lewis [email protected] wrote:

@marcules https://github.com/marcules sorry to bother you, is there any chance you could enable this repo on travis? https://travis-ci.org/ Should only take < 1 min 😃

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/marcules/karma-remap-istanbul/issues/29#issuecomment-267924742, or mute the thread https://github.com/notifications/unsubscribe-auth/ACVudEo3nth3kP7KHtxrT8E0Q1hk7Kvgks5rJlT4gaJpZM4LFS42 .

marcules avatar Dec 20 '16 08:12 marcules

Awesome, thanks! 😃

mattlewis92 avatar Dec 20 '16 08:12 mattlewis92

@marcules any chance you could enable travis please when you have a sec? Thanks, and happy new year! 😃

mattlewis92 avatar Jan 02 '17 14:01 mattlewis92