savegame-editors icon indicating copy to clipboard operation
savegame-editors copied to clipboard

TOTK Request: Horse editor

Open MJr0019 opened this issue 2 years ago • 59 comments
trafficstars

First I would like to thank you for all your work so far.

thank you very much

could you add the function to edit the colors of the horses?


En primer lugar me gustaría darle las gracias por todo su trabajo hasta ahora.

muchas gracias

¿podrías agregar la función para editar los colores de los caballos?

MJr0019 avatar May 12 '23 15:05 MJr0019

Feel for this. My botw horses didnt transfer , and would love to edit them in.

JonJaded avatar May 15 '23 21:05 JonJaded

The issue title mentions BOTW, I'm not sure if that was a mistake. You can edit BOTW horses already. Did you mean TOTK? If that's the case, the horse editor can come if you provide a savegame with horse data. It will be very helpful if it has five horses and you also provide their names, saddles, etc.

marcrobledo avatar May 16 '23 06:05 marcrobledo

Here's my save. Hopes this helps.

Askye -MAX BOND- Towing Harness Pips -MAX BOND- Giant Horse Harness Blindye -95 BOND- Default Harness Marledo -36 BOND- Default Harness Ichekse -00 BOND- Towing Harness Jadeite -30 BOND- Towing Harness [1744 -1923 0012] Untamed Horse -?? BOND- No Harness [1735 -1942 0012]

progress.zip

JonJaded avatar May 16 '23 20:05 JonJaded

Question though, for my morbid curiousity. I opened my save in HxD and I'm just wondering how does parsing the info work? It's clearly not plaintext so how do you 'unencrypt' or demangle the save data structure? Is it just diffing until you find the pattern?

JonJaded avatar May 17 '23 06:05 JonJaded

Offsets for v1.0.0 (for v1.1.0 need to add +0x38):

0010E008:Horse Name 01 0010E028:Horse Name 02 ...+0x20

0008A0F0:Horse Type 01 0008A130:Horse Type 02 ...+0x40

GameRomHorse00L is the Large Horse from botw GameRomHorseGold is the new Gold Horse GameRomHorse01L is the new Large White Horse

The only problem is that changing the horse type doesn't change the image preview when choosing horses. Also need to find the stats and equipment.

Karlos007 avatar May 17 '23 09:05 Karlos007

The only problem is that changing the horse type doesn't change the image preview when choosing horses. Also need to find the stats and equipment.

This is another issue I've heard multiple times. The game seems to have a cached copy of a lot of the thumbnails which don't dynamicly update (likely because the game doesn't expect them to spontaneously change.) Not sure on what a fix would be.

JonJaded avatar May 17 '23 15:05 JonJaded

When ever I open my save in the editor I cant edit my horses. I have horses registered, but the tab is grayed out and I cant click on it. Is there something I am doing wrong?

Ozymandias07 avatar May 18 '23 20:05 Ozymandias07

but the tab is grayed out

The feature is not yet implemented. It has not even been a week since release; gotta slow down a bit.

JonJaded avatar May 18 '23 20:05 JonJaded

oh whoops i thought since it was closed it means it was implemented

Ozymandias07 avatar May 18 '23 20:05 Ozymandias07

Oh no, the threads that say closed are the dupe thread. This one is still open. If you want to help marcro, please zip your save file and give a table of the horse information as I did in here. https://github.com/marcrobledo/savegame-editors/issues/169#issuecomment-1550336369

JonJaded avatar May 18 '23 21:05 JonJaded

Here is my save if it helps progress.zip

Ozymandias07 avatar May 19 '23 17:05 Ozymandias07

Epona Max Bond Regular Epona equipment Goldy Max Bond Extravagant Saddle Spirit Max Bond Regular Giant Horse equipment Dairy 0 Bond Traveler's Saddle Banana 0 Bond Regular Saddle Blue Man 0 Bond Regular Saddle

I dont know if this will help either

Ozymandias07 avatar May 19 '23 17:05 Ozymandias07

Giant Horse equipment

Ah you're right! One of my horses is the giant horse, they use a seperate harness type as compared to regular horses (as they did in BOTW.) I made a slight error in my horse inventory labeling (specifically Pips) @marcrobledo , it's fixed now.

JonJaded avatar May 19 '23 18:05 JonJaded

Added a very basic horse editor, it can edit the horse type for now.

marcrobledo avatar May 19 '23 20:05 marcrobledo

The horse name editor is currently disabled for security reasons.

Can anyone share a savegame with japanese/chinese/korean characters for horses so I can check if it's safe?

marcrobledo avatar May 21 '23 07:05 marcrobledo

The horse name editor is currently disabled for security reasons.

Can anyone share a savegame with japanese/chinese/korean characters for horses so I can check if it's safe?

image Ryujinx.zip I tamed 3 horses on slots 7 8 9 game v1.1.1

Karlos007 avatar May 21 '23 08:05 Karlos007

The game still has the same 9 character limit from BOTW. I saw in the sav file that after each character of a horses name is a00 spacer, and I'm sure that's what you're worried about.

JonJaded avatar May 21 '23 08:05 JonJaded

Oh, wait, so there is room for more than six horses? I recall someone here saying it was six. That would explain why the savegame horse data array length is 10.

marcrobledo avatar May 21 '23 08:05 marcrobledo

Yes you unlock more slots by getting points at the stables

Dominic-Dom avatar May 21 '23 08:05 Dominic-Dom

Oh, wait, so there is room for more than six horses?

Yes there is, I definetly should've mentioned that. you start with 6 slots, (because the game transfers over 5 of your horses from BOTW + first horse you capture.) If it doesn't transfer, those slots are still available to you. You can then later upgrade your slot count after a certain amount of tickets at the stables.

As you said, 10 is the max.

JonJaded avatar May 21 '23 08:05 JonJaded

image The slot 6 should be GameRomHorseSpPattern Is a normal looking horse but you get it from a quest. Maybe it's a unique type.

Karlos007 avatar May 21 '23 08:05 Karlos007

Added horse name editor in d9e7394

marcrobledo avatar May 21 '23 09:05 marcrobledo

Thanks for add editor

MJr0019 avatar May 21 '23 16:05 MJr0019

Can I request this topic to be reopened? There are a couple of things that could be implemented.

Final additions:

  • Adding horses directly (up to 10)
  • Saddle editor

Unnecessary stuff:

  • Untamed horse type
  • Untamed horse location

Really uneeded finishing touches:

  • Bond editor? (Bond is very easy to max out so we probably don't need that.)

JonJaded avatar May 21 '23 17:05 JonJaded

image The slot 6 should be GameRomHorseSpPattern Is a normal looking horse but you get it from a quest.

Would you happen to know if this changes the cap on the amount of horses (like in #221) where's it's a 10 + 1 reserved or is this a unique horse?

If you tell me where you got this horse quest, I can go test.

JonJaded avatar May 21 '23 17:05 JonJaded

image The slot 6 should be GameRomHorseSpPattern Is a normal looking horse but you get it from a quest.

Would you happen to know if this changes the cap on the amount of horses (like in #221) where's it's a 10 + 1 reserved or is this a unique horse?

If you tell me where you got this horse quest, I can go test.

It's on Lookout Landing but a bit later in the story when you build the stable It doesn't seem to change the cap

Karlos007 avatar May 21 '23 17:05 Karlos007

I have tested the current version of the horse editor and it looks like Satori and the bone horses can be edited in without the game crashing (like it would in BoTW but that was a long time ago. Maybe the horse editor at the time wasn't setup to change equipment and perhaps having no equipment assigned is why they crashed the game? Someone should revisit that. ;) )

They have bugged hairdo's since the current horse editor is limited and the horse I replaced with the bone/Satori ones inherited the equipment settings/stats of the horse it was replacing. The Satori horse ends in Nushi and the bone ones...end in bone. I specifically tested the one that ended in AllDay. Did not try pulling out the non AllDay one. That one might have died the instant I pulled him out since it was day time and I'm not sure how the game would handle it. The AllDay one didn't care that it was day time.

Another interesting note, the Satori one did not run off and vanish like he normally does so save editing him into the stable seemed to make him permanent. Though currently does not have his normal infinite stamina stats due to the limited editor. :P

I was able to assign different equipment to both horses without issue though I wonder if that continues to be the case once the horse stats are properly set for them.

ApacheThunder avatar May 21 '23 23:05 ApacheThunder

Hey! I know you have a lot on your plate, and I really, really appreciate you going out of your way to make all this for us! That said, I wanted to add on to this here and mention that, in Yuzu, a lot of the horse labels can't seem to change - patterns don't seem to change when changing the game rom horse. I'm not sure if that's because of the upgrade system, but I felt it wqas worth mentioning. It's not a huge deal to me, though.

The main thing I wanted to request was if you could attempt to port over the horse gear and mane editing feature from the BotW editor. I edited in the old giant horse from BotW, but it still has the old mane and saddle, and I haven't been able to switch it over to the giant horse gear and mane. I'd like to be able to switch them over, if possible

Lucifiish avatar May 22 '23 15:05 Lucifiish

Since I confirmed Satori and Skeleton horses don't crash the game upon editing them into the stable it might be worth researching if you could assign wildlife stuff to horse slots too. ;)

Though understandable if this isn't possible if the game doesn't have flags for them. Interesting the game would have flags for Satori and skeleton horses though. Perhaps a mistake of the editor? I checked the BoTW one and it appears they no longer list Satori and skeleton horses. I definitely do remember being able to assign them at one point. The editor at the time didn't have ability to alter equipment though so improper equipment settings might be why they crashed the game? Would be interesting to revisit that.

The current version of the editor for ToTK preserves the stats/equipment of the horse previously in the slot when assigning a different one and this "might" be why Satori/Skeleton horses aren't crashing the game this time around.

ApacheThunder avatar May 22 '23 16:05 ApacheThunder

Since I confirmed Satori and Skeleton horses don't crash the game upon editing them into the stable it might be worth researching if you could assign wildlife stuff to horse slots too. ;)

Though understandable if this isn't possible if the game doesn't have flags for them. Interesting the game would have flags for Satori and skeleton horses though. Perhaps a mistake of the editor? I checked the BoTW one and it appears they no longer list Satori and skeleton horses. I definitely do remember being able to assign them at one point. The editor at the time didn't have ability to alter equipment though so improper equipment settings might be why they crashed the game? Would be interesting to revisit that.

The current version of the editor for ToTK preserves the stats/equipment of the horse previously in the slot when assigning a different one and this "might" be why Satori/Skeleton horses aren't crashing the game this time around.

How did you go about editing gear on horses?

Lucifiish avatar May 23 '23 00:05 Lucifiish