Marco Costa
Marco Costa
This has been implemented in release `1.16.0`.
Sorry for the long delay. I'm working on getting Rack 3 support merged (including this fix). I have to recreate CI because I was using Travis before, so it's not...
> Has anyone here considered the possibility of ONLY the first sidekiq attempt (the web request going async _immediately_ afterwards for many apps) picking up the trace context... and further...
This whole PR was pretty much done in #2128
👋 sorry for the delay, if you'd like for `active_record` and `active_support` spans to not be generated, you can remove these lies altogether from your configuration. ```diff - c.tracing.instrument(:active_record, service_name:...
It looks like the span_id value in the traceparent: https://github.com/DataDog/dd-trace-rb/blob/c9530f68267982d1c2918c714e10e6c03c8047c1/lib/datadog/tracing/distributed/trace_context.rb#L108 will always be equal to the value of the new tag: https://github.com/DataDog/dd-trace-rb/blob/c9530f68267982d1c2918c714e10e6c03c8047c1/lib/datadog/tracing/distributed/trace_context.rb#L150 Doesn't this mean the new tagged introduced in...
I think I found my answer. It looks like when both values diverge, when extracting remote distributed headers, we should use the value of the tag instead of the value...
@mabdinur makes sense, thank you! I think my comment is still correct and should be implemented: > It looks like when both values diverge, when extracting remote distributed headers, we...
👋 @cjubb39, thank you so much for this request. We are also working on this feature ourselves, and your PR looks like a great contribution to get this work delivered....
This was shipped in #3585, thank you for your contribution @cjubb39!