Marco Costa

My first attempt at implementing `peer.service` showed that the logic required to tag spans as external peer services, across all integrations, turned out very inconsistent. There are different ways to...

Regarding the lint failure, rebasing with master will fix it now.

@mizukami234, to aid with our discussion, would you know long this query actually is (in number bytes or characters)?

👋 @buddhistpirate, if I understand your requirements correct, as "Capture 100% of Sidekiq traces. Other traces, capture 15%.", you can implement this ingestion control using the following configuration: ```ruby #...

👋, @AnalogJ, thanks for bringing this up. Feature parity is important. We'll talk to our team to see where this feature lands in our roadmap. Future reference for the implementer:...

Hey @kohder, this seems like a straightforward suggestion. I'll add it to our feature request list. I doesn't seem too different from our existing `Net::HTTP` integration, so I don't see...

We have a related update: [ActionMailer integration has been merged](https://github.com/DataDog/dd-trace-rb/pull/1280) and will be shipped with the next `ddtrace` release. If you happen to use `Net::SMTP` through ActionMailer this integration might...

@Germanunkol No worries, take your time.

One suggestion I have is to add default middleware parameters to the default validation list. ```ruby valid_middleware_keys(middlewares) + Excon::VALID_CONNECTION_KEYS + Excon::DEFAULT_MIDDLEWARE_PARAMETER_KEYS ```

@geemus default values for middleware keys seem like a great approach! Given that `Excon::Middleware::Base.valid_parameter_keys` is already in the public, I'm guessing adding another method to `Excon::Middleware::Base` that returns a hash...