Update to the new version of delta is failed

[anuvyklack]

Update to the new version of delta is failed:

$ bin update
   • /home/anuvyklack/.local/bin/delta 0.12.0 -> 0.12.1 (https://github.com/dandavison/delta/releases/tag/0.12.1)

Multiple matches found, please select one:

 [1] delta-0.12.1-x86_64-unknown-linux-gnu.tar.gz
 [2] delta-0.12.1-x86_64-unknown-linux-musl.tar.gz
 Select an option: 2
   • Starting download of https://api.github.com/repos/dandavison/delta/releases/assets/58722379
2.56 MiB / 2.56 MiB [-----------] 100.00% 3.35 MiB p/s 1s
   ⨯ command failed            error=No files found in tar archive. PackagePath [delta-0.12.0-x86_64-unknown-linux-musl/delta]

However in the tar.gz archive there is bin file:

.rwxr-xr-x 5.6M delta
.rw-r--r-- 1.1k LICENSE
.rw-r--r-- 6.5k README.md

[marcosnils]

Do you have the latest bin version? Seems to be workng here with 0.13.0

# bin --version
bin version 0.13.0
commit: c186a5eeb163c8efaa43fd3b99f7caa15dc6a889
built at: 2022-01-26T05:21:43Z
built by: goreleaser
# bin install https://github.com/dandavison/delta/releases/tag/0.12.1
   • Getting 0.12.1 release for dandavison/delta

Multiple matches found, please select one:

 [1] delta-0.12.1-x86_64-unknown-linux-gnu.tar.gz
 [2] delta-0.12.1-x86_64-unknown-linux-musl.tar.gz
 Select an option: 2
   • Starting download of https://api.github.com/repos/dandavison/delta/releases/assets/58722379
2.56 MiB / 2.56 MiB [--------------------------------------------------------------------------------------------------------------------------------------------------------] 100.00% ? p/s 0s

Multiple matches found, please select one:

 [1] delta-0.12.1-x86_64-unknown-linux-musl/README.md
 [2] delta-0.12.1-x86_64-unknown-linux-musl/delta
 [3] delta-0.12.1-x86_64-unknown-linux-musl/LICENSE
 Select an option:

[anuvyklack]

My bin is manage itself.

$ bin --version
bin version 0.13.1
commit: d8ffb9fc666ae9f75afa2981d069b2b654c0d0bc
built at: 2022-03-01T05:10:49Z
built by: goreleaser

[anuvyklack]

bin install https://github.com/dandavison/delta/releases/tag/0.12.1

works for me. But bin update not.

[marcosnils]

oh! it's bin update my bad. Checking

[marcosnils]

in the meantime, if you use the -p flag in bin update that should allow you to select new binaries.

[anuvyklack]

Yes it works!

[skorokithakis]

Fails for me:

17:33:42 $ bin update
   • /home/stavros/Documents/Various/bin/rclone v1.58.0 -> v1.58.1 (https://github.com/rclone/rclone/releases/tag/v1.58.1)

Do you want to continue? [Y/n] y
   • Getting v1.58.1 release for rclone/rclone
   • Starting download of https://api.github.com/repos/rclone/rclone/releases/assets/64009550
13.94 MiB / 13.94 MiB [----------------------------] 100.00% 2.96 MiB p/s 5s
   ⨯ command failed            error=No files found in zip archive. PackagePath [rclone-v1.58.0-linux-amd64/rclone]


17:34:06 $ bin --version
bin version 0.15.0
commit: a798f72f7d3cecb24a2078c391858293479f7eb4
built at: 2022-05-28T19:52:52Z
built by: goreleaser

[korpa]

I have the same issue with rclone as @skorokithakis

bin update -p as workaround was successful.

[francilioaraujo]

I had the same problem with the bellow bin version:

bin version 0.15.1
commit: 9937e08209b8d266e2266d4454205acb4fdfe8e7
built at: 2022-07-04T19:52:31Z
built by: goreleaser

This happens with https://github.com/sharkdp/bat as well. I did some debugging and found out the gziped tar package path is version dependent, so the last check on this line will fail https://github.com/marcosnils/bin/blob/4d8bde37d10ac90e73912c4d85c88b5b6552ac36/pkg/assets/assets.go#L361 The f.opts.PackagePath will have the previous version, while the header.Name path will have the current one.

[marcosnils]

@francilioaraujo are you using the -p flag on update? That should allow you to pick the new package. I'm working on a fix to make this update process a bit more "smart" to detect the correct file.

[francilioaraujo]

@francilioaraujo are you using the -p flag on update? That should allow you to pick the new package.

Yes. The -p solves it. I did the debugging before I found this issue

[marcosnils]

I did the debugging before I found this issue

The error message in 0.15.1 should print a hint about using the -p flag.

[francilioaraujo]

The error message in 0.15.1 should print a hint about using the -p flag.

Indeed it does. I didn't see it before. Thank you