layer icon indicating copy to clipboard operation
layer copied to clipboard

remove rgeos dependency by replacing rgeos::gBuffer with sf::st_buffer, fixes #15

Open e-kotov opened this issue 2 years ago • 1 comments

Fixes #15 .

I have replaced rgeos::gBuffer with sf::st_buffer effectively removing the dependency on deprecated rgeos package. This solves the issue with not being able to install the package even from GitHub, as rgeos is not installable anymore without some hoops. Hopefully, this will also help with restoring the package to CRAN.

e-kotov avatar Feb 05 '24 10:02 e-kotov

@marcosci , hi, this is a kind reminder about the quick fix that will allow to return the package back to CRAN.

e-kotov avatar Apr 17 '24 18:04 e-kotov

@marcosci, @z3tt would be really great to implement the fix and put the package on CRAN. Do you have time to do it? If not, I could take over as a package maintainer.

e-kotov avatar Jan 11 '25 10:01 e-kotov

Thanks for your efforts @e-kotov as well as the reminder!

@marcosci, which option do you prefer? Seems you're not really active on the package issues so maybe makes sense to team up?

z3tt avatar Jan 23 '25 12:01 z3tt

Sure thing, I'll add e-kotov to the repo :)

marcosci avatar Jan 23 '25 14:01 marcosci

Let me know if that worked :)

marcosci avatar Jan 23 '25 14:01 marcosci

@marcosci yes that did work, I accepted the invitation. So should I go ahead and submit the fixed version to CRAN with myself as the new maintainer? (needless to say, but of course with all the prior authorship credits)

e-kotov avatar Jan 23 '25 16:01 e-kotov

Sure thing, go ahead 👍🏻

marcosci avatar Jan 23 '25 17:01 marcosci

Sure thing, go ahead 👍🏻

👍

e-kotov avatar Jan 23 '25 18:01 e-kotov