node-memwatch icon indicating copy to clipboard operation
node-memwatch copied to clipboard

Published 20 hours ago • verified publisher icon marcominetti

NodeJS 12

Open pavel-yasiukevich opened this issue 5 years ago • 3 comments

I added v8::Isolate and v8::Context as method parameters since deprecated API was removed. I also got the rid of legacy v8::Handle replacing it with v8::Local. Tested both on Ubuntu and Windows for the following major NodeJS versions: 8, 10, 12.

pavel-yasiukevich avatar Sep 29 '19 13:09 pavel-yasiukevich

@marcominetti , can we make progress towards merging this?

millerick avatar Oct 31 '19 04:10 millerick

@marcominetti tested npm install ing these changes with node v10 and v12. Successfully done.

bimalkant-lauhny avatar Mar 27 '20 09:03 bimalkant-lauhny

I've gone ahead and merged this request on my own fork and published to NPM @pavel-yasiukevich, please see https://github.com/atsjj/memwatch/releases/tag/1.0.0.

I needed this patch and figured others would benefit from it too! Much appreciation to those who have contributed, I feel this is the least I could do to help.

atsjj avatar May 07 '20 20:05 atsjj