Marco Minerva

Results 74 comments of Marco Minerva

Could you please give me an example of an ASP.NET Core library that references **Microsoft.CodeAnalysis.CSharp** v4.5?

The `Logs` property was just an idea, but we can remove it for now, the important thing is how to understand if the pipeline actually failed. I have added the...

Analyzing the current implementation based on concrete types: https://github.com/microsoft/kernel-memory/blob/775301a1cdd84ab7a54458d3fa453a8763c0744d/service/Abstractions/KernelMemoryBuilderExtensions.cs#L122-L140 https://github.com/microsoft/kernel-memory/blob/775301a1cdd84ab7a54458d3fa453a8763c0744d/service/Core/KernelMemoryBuilder.cs#L183-L187 I see that the same instance is added as Singleton for the retrieval (line 132) and to a list of...

@dluc, I have made a draft PR to showcase my idea: https://github.com/microsoft/kernel-memory/pull/444. I know that is a structural change and requires a lot of effort, but perhaps it could be...

> Question: how are services resolved if a keyed dependency is missing? The framework should fall back to a default implementation, does it? Actually, I have noticed that, if I...

I have tried with Azure Queues, I have verified that the message is moved to a poison queue after a certain number of retries. However, the number of retries is...

If I correctly understand the meaning of the `requeue` parameter: https://github.com/microsoft/kernel-memory/blob/f266b25b1c385871abc6253a93c21b44fdf16837/extensions/RabbitMQ/RabbitMQPipeline.cs#L139 It enqueue the a new message again in the queue, with a new expiration time, endlessly.

By the way, there are some issues in `RabbitMQPipeline`: https://github.com/microsoft/kernel-memory/blob/f266b25b1c385871abc6253a93c21b44fdf16837/extensions/RabbitMQ/RabbitMQPipeline.cs#L111 ![image](https://github.com/microsoft/kernel-memory/assets/3522534/9dcb5cd3-6d76-4ef2-bac2-43a4b6221be7) ![image](https://github.com/microsoft/kernel-memory/assets/3522534/bd9829de-f178-4833-8e91-4c6c477a6a87) It seems that all the properties of `BasicProperties` are `null`.

@dluc I have made a PR to set the missing properties in RabbitMQ: https://github.com/microsoft/kernel-memory/pull/454. After that, I think that also in `RabbitMQPipeline` we should handle a max retries number and...

So, do you prefer using such solutions instead of the quorum queue?