react-native-big-list icon indicating copy to clipboard operation
react-native-big-list copied to clipboard

bug / contentContainerStyle is also affecting renderHeader

Open dougg0k opened this issue 4 years ago • 5 comments

contentContainerStyle is also affecting renderHeader, would be the same thing as just wrapping BigList in a View. So, it's not working only in the content.

dougg0k avatar Jun 12 '21 12:06 dougg0k

Would be too hard to give the lib consumer a prop so he would choose to make renderHeader a part or not, of the recycle list content? In my case the renderHeader is a bit heavier than normal, that could be the same situation for others.

In FlatList for example the only way is using their renderHeader alternative to have FlatList in a screen, otherwise would need to wrap all in a ScrollView, and that make FlatList pointless.

dougg0k avatar Jun 12 '21 12:06 dougg0k

contentContainerStyle is also affecting renderHeader, would be the same thing as just wrapping BigList in a View. So, it's not working only in the content.

Yes, it's normal isn't a bug. Anyway send your mockup about your expectation.

Would be too hard to give the lib consumer a prop so he would choose to make renderHeader a part or not, of the recycle list content? In my case the renderHeader is a bit heavier than normal, that could be the same situation for others.

In FlatList for example the only way is using their renderHeader alternative to have FlatList in a screen, otherwise would need to wrap all in a ScrollView, and that make FlatList pointless.

Maybe could be possibile only for Header and Footer. I need to try it and after I'll give you a feedback about it.

marcocesarato avatar Jun 15 '21 16:06 marcocesarato

I mean, would be cool to have separate styling option as props, one for the renderHeader and another for the renderItem list which already is the contentContainerStyle. I think that's how FlatList work.

In FlatList contentContainerStyle does not affect header nor footer.

https://reactnative.dev/docs/flatlist#listheadercomponentstyle It also has a separate style obj for the footer. https://reactnative.dev/docs/flatlist#listfootercomponentstyle

dougg0k avatar Jun 15 '21 17:06 dougg0k

I mean, would be cool to have separate styling option as props, one for the renderHeader and another for the renderItem list which already is the contentContainerStyle. I think that's how FlatList work.

In FlatList contentContainerStyle does not affect header nor footer.

https://reactnative.dev/docs/flatlist#listheadercomponentstyle It also has a separate style obj for the footer. https://reactnative.dev/docs/flatlist#listfootercomponentstyle

I add a static header and footer, so they shouldn't be re-rendered. Released on 1.3.8.

About ListFooterComponentStyle and ListHeaderComponentStyle already exists if you use ListHeaderComponent or ListFooterComponent but they are not really needed because your children can be styled with flex: 1 to nullify the parent and the width and height can't be changed (for calculate the height of the view using processor) and they are available only for compatibility. columnWrapperStyle can be implemented but, as for ListFooterComponentStyle, I must to overwrite height and width so its only for compatibility.

marcocesarato avatar Jun 16 '21 20:06 marcocesarato

Nice, thanks.

dougg0k avatar Sep 03 '21 18:09 dougg0k